[CELEBORN-1845][CIP-14] Add MessageDispatcher to cppClient #3077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HolyLow
force-pushed
the
issue/celeborn-1845-add-message-dispatcher-to-cpp-client
branch
from
24e4ba2 to
57a3dca
Compare
FMX
reviewed
Jan 21, 2025
| return p.getFuture(); | ||
| }); | ||
|
|
||
| this->pipeline_->write(std::move(toSendMsg)); |
There was a problem hiding this comment.
I have a question here, does this writing have the semantic of flush?
There was a problem hiding this comment.
The message would be transferred through the pipeline immediately, and there is no interface related to flush in Pipeline or OutboundLink (the component layers when sending out a message), so we could safely assume that this write() interface already has flushing semantic though there is no implementation guarantee.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds MessageDispatcher class to cppClient.
Why are the changes needed?
MessageDispatcher is responsible for recording the connection between MessageFuture and MessagePromise, which is the base of async message transferring mechanism.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Compilation and UTs.